Double-Charged at Checkout

Easy

· Frontend

Incident

SEV-1

BUG-5150

Priority: Critical · reported by support (chargebacks!)

Time to fix: 10 min

Failing checks on the shipped build

  • a repeated key charges exactly once

    one charge for one key: expected 1 but got 2

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the value the screen shows back through the state and the pure helpers that compute it; the view is usually only the messenger.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Inspired by

Stripe idempotency

Inspired by the double-submit bugs every payments team has fought (and the idempotency keys Stripe popularised to kill them). An impatient double-click sends the same request twice — the processor must charge exactly once per idempotency key.

Fix chargeProcessor.js.

Code map

// Charges with idempotency keys: one key, one charge — ever.
var charges = [];
var seenKeys = {};
var nextId = 1;

exports.process = function (key, amountCents) {
  var charge = { id: "ch_" + nextId, amount: amountCents, key: key };
  nextId++;
  charges.push(charge);
  if (!seenKeys[key]) {
    seenKeys[key] = charge;
  }
  return seenKeys[key];
};

exports.allCharges = function () { return charges.slice(); };
exports.resetAll = function () { charges = []; seenKeys = {}; nextId = 1; };

Sign in to edit the file, run the tests and submit a fix

A free account — no card, no trial clock. You come straight back here.

Double-Charged at Checkout — JavaScript Bug Hunt

Inspired by the double-submit bugs every payments team has fought (and the idempotency keys Stripe popularised to kill them).

  • Language: JavaScript
  • Layer: Frontend
  • Difficulty: Easy
  • Concepts: Idempotency, Payments
  • Modelled on: Stripe idempotency
  • Visible tests: a repeated key charges exactly once; different keys create separate charges
  • Reward: 50 XP for a complete fix

Incident

  • Severity: SEV-1 (priority: Critical)
  • Ticket: BUG-5150
  • Reported by: support (chargebacks!)
  • Time to fix: 10 minutes, the target for an easy incident

Failing checks on the shipped build

  • a repeated key charges exactly once — one charge for one key: expected 1 but got 2

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the value the screen shows back through the state and the pure helpers that compute it; the view is usually only the messenger.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Briefing

Inspired by the double-submit bugs every payments team has fought (and the idempotency keys Stripe popularised to kill them). An impatient double-click sends the same request twice — the processor must charge exactly once per idempotency key.

Fix chargeProcessor.js.

Bug report

BUG-5150 · Priority: Critical · Reported by: support (chargebacks!)

Contract: process(key, amountCents) — a repeated key must be a no-op that returns the ORIGINAL charge (same id, same amount), creating nothing new.

Observed: double-clicks create two charges; the retry even returns a different charge id than the first attempt.

Logs

[charge] key=ck_1a2b amount=4999 -> ch_001
[charge] key=ck_1a2b amount=4999 -> ch_002   <- duplicate!

The code as shipped

src/pay/chargeProcessor.js (editable)

// Charges with idempotency keys: one key, one charge — ever.
var charges = [];
var seenKeys = {};
var nextId = 1;

exports.process = function (key, amountCents) {
  var charge = { id: "ch_" + nextId, amount: amountCents, key: key };
  nextId++;
  charges.push(charge);
  if (!seenKeys[key]) {
    seenKeys[key] = charge;
  }
  return seenKeys[key];
};

exports.allCharges = function () { return charges.slice(); };
exports.resetAll = function () { charges = []; seenKeys = {}; nextId = 1; };

Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More JavaScript bug hunts.