The Check That Hadn't Cleared

Medium

· Backend

Incident

SEV-1

BUG-JPM-0902

Priority: Critical · reported by fraud operations

Time to fix: 20 min

Failing checks on the shipped build

  • a large uncleared check is mostly held

    100 cleared + 225 immediate: expected 325 but got 10100

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Inspired by

JPMorgan Chase · 2024

Modelled on the JPMorgan Chase "infinite money glitch" (August–September 2024): videos spread on social media showing people depositing checks — often bad ones, or checks written to themselves — and withdrawing the money before the checks bounced. Chase called it check fraud, closed the gap, and later sued some customers to recover the funds.

This project is a reconstruction of the underlying mistake: availability.js counts a deposited check as spendable the moment it is deposited, whether or not it has cleared.

Fix availableBalance so uncleared deposits are available only up to the policy's immediate amount.

Code map

var policy = require("./policy");

exports.availableBalance = function (account) {
  var total = 0;
  for (var i = 0; i < account.entries.length; i++) {
    var e = account.entries[i];
    if (e.type === "deposit") {
      if (e.status !== "returned") total += e.amount;
    } else {
      total -= e.amount;
    }
  }
  return total;
};

exports.withdraw = function (account, amount) {
  if (!(amount > 0) || amount > exports.availableBalance(account)) return false;
  account.entries.push({ type: "withdrawal", amount: amount });
  return true;
};

Sign in to edit the file, run the tests and submit a fix

A free account — no card, no trial clock. You come straight back here.

The Check That Hadn't Cleared — JavaScript Bug Hunt

Modelled on the JPMorgan Chase "infinite money glitch" (August–September 2024): videos spread on social media showing people depositing checks — often bad…

  • Language: JavaScript
  • Layer: Backend
  • Difficulty: Medium
  • Concepts: Money, Validation
  • Modelled on: JPMorgan Chase · 2024
  • Visible tests: cleared money is available; a large uncleared check is mostly held
  • Reward: 50 XP for a complete fix

Incident

  • Severity: SEV-1 (priority: Critical)
  • Ticket: BUG-JPM-0902
  • Reported by: fraud operations
  • Time to fix: 20 minutes, the target for a medium incident

Failing checks on the shipped build

  • a large uncleared check is mostly held — 100 cleared + 225 immediate: expected 325 but got 10100

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Briefing

Modelled on the JPMorgan Chase "infinite money glitch" (August–September 2024): videos spread on social media showing people depositing checks — often bad ones, or checks written to themselves — and withdrawing the money before the checks bounced. Chase called it check fraud, closed the gap, and later sued some customers to recover the funds.

This project is a reconstruction of the underlying mistake: availability.js counts a deposited check as spendable the moment it is deposited, whether or not it has cleared.

Fix availableBalance so uncleared deposits are available only up to the policy's immediate amount.

Bug report

BUG-JPM-0902 · Priority: Critical · Reported by: fraud operations

account.entries holds { type: "deposit", amount, status } (status "cleared", "pending" or "returned") and { type: "withdrawal", amount }.

availableBalance(account) = sum of CLEARED deposits

  • sum of withdrawals
  • min(policy.IMMEDIATE_LIMIT, sum of PENDING deposits)

Returned deposits count for nothing. The immediate amount is one allowance across all pending deposits, not one per check.

withdraw(account, amount) succeeds (records a withdrawal, returns true) only if 0 < amount <= availableBalance(account); otherwise returns false and records nothing.

Observed: a $10,000 check deposited a minute ago can be withdrawn in full.

Logs

[atm 0931] acct ****5521 deposit check 10000.00 status=pending
[atm 0931] acct ****5521 withdraw 9800.00 approved (available 10100.00)
[returns] check 0048 returned: NSF

The code as shipped

src/bank/availability.js (editable)

var policy = require("./policy");

exports.availableBalance = function (account) {
  var total = 0;
  for (var i = 0; i < account.entries.length; i++) {
    var e = account.entries[i];
    if (e.type === "deposit") {
      if (e.status !== "returned") total += e.amount;
    } else {
      total -= e.amount;
    }
  }
  return total;
};

exports.withdraw = function (account, amount) {
  if (!(amount > 0) || amount > exports.availableBalance(account)) return false;
  account.entries.push({ type: "withdrawal", amount: amount });
  return true;
};

Read-only context: src/bank/policy.js.

Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More JavaScript bug hunts.