The Folder Called .GIT

Medium

· Backend

Incident

SEV-1

BUG-CVE-2014-9390

Priority: Critical · reported by security

Time to fix: 20 min

Failing checks on the shipped build

  • other spellings of .git are blocked

    .GIT: expected a truthy value but got false

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Inspired by

Git · CVE-2014-9390

Modelled on Git CVE-2014-9390 (December 2014). Git refused to check out a tree entry named .git, but compared the name exactly. On case-insensitive filesystems — Windows and macOS by default — a malicious repository could ship .Git/config or .GIT/config, and checking it out overwrote the repository's own configuration, which can lead to arbitrary command execution. Fixed Git releases compare the way the filesystem does (and also reject names that HFS+ treats as equivalent).

This reconstruction's verify_path blocks only the exact spelling.

Fix verify_path so no spelling of .git passes.

Code map

BLOCKED = ("", ".", "..", ".git")


def verify_path(path):
    if path == "" or path.startswith("/"):
        return False
    for part in path.split("/"):
        if part in BLOCKED:
            return False
    return True

Sign in to edit the file, run the tests and submit a fix

A free account — no card, no trial clock. You come straight back here.

The Folder Called .GIT — Python Bug Hunt

Modelled on Git CVE-2014-9390 (December 2014). Git refused to check out a tree entry named .git, but compared the name exactly.

  • Language: Python
  • Layer: Backend
  • Difficulty: Medium
  • Concepts: Security, Validation, Unicode
  • Modelled on: Git · CVE-2014-9390
  • Visible tests: ordinary paths are allowed; other spellings of .git are blocked
  • Reward: 50 XP for a complete fix

Incident

  • Severity: SEV-1 (priority: Critical)
  • Ticket: BUG-CVE-2014-9390
  • Reported by: security
  • Time to fix: 20 minutes, the target for a medium incident

Failing checks on the shipped build

  • other spellings of .git are blocked — .GIT: expected a truthy value but got false

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Briefing

Modelled on Git CVE-2014-9390 (December 2014). Git refused to check out a tree entry named .git, but compared the name exactly. On case-insensitive filesystems — Windows and macOS by default — a malicious repository could ship .Git/config or .GIT/config, and checking it out overwrote the repository's own configuration, which can lead to arbitrary command execution. Fixed Git releases compare the way the filesystem does (and also reject names that HFS+ treats as equivalent).

This reconstruction's verify_path blocks only the exact spelling.

Fix verify_path so no spelling of .git passes.

Bug report

BUG-CVE-2014-9390 · Priority: Critical · Reported by: security

verify_path(path) returns False when ANY of these hold, True otherwise:

  • path is empty or starts with "/"
  • a component (split on "/") is empty, "." or ".."
  • a component equals ".git" compared case-insensitively (".GIT", ".Git", ".gIt" … at any depth)

Names that merely start with .git (".gitignore", ".github") are fine. checkout() validates every path before writing any file.

Observed: cloning a repository containing .Git/config on a Mac replaced .git/config with the repository's copy.

Logs

[checkout] writing .Git/config (fs: case-insensitive)
[checkout] .git/config modified by checkout

The code as shipped

src/checkout/paths.py (editable)

BLOCKED = ("", ".", "..", ".git")


def verify_path(path):
    if path == "" or path.startswith("/"):
        return False
    for part in path.split("/"):
        if part in BLOCKED:
            return False
    return True

Read-only context: src/checkout/checkout.py, src/checkout/fs.py.

Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More Python bug hunts.