The Payment Method Called Nothing

Medium

· Backend

Incident

SEV-1

BUG-RIDE-FREE

Priority: Critical (revenue) · reported by bug bounty

Time to fix: 20 min

Failing checks on the shipped build

  • an unsupported payment type is refused before dispatch

    expected {"ok":false,"error":"invalid_payment_method"} but got {"ok":true,"trip":{"id":"trip-1","rider":"rider-7","paymentMethodId":"pm_x","fare":1250,"status":"dispatched"}}

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Inspired by

Uber · 2017

Modelled on the Uber free-rides bug that security researcher Anand Prakash disclosed in 2017 after reporting it through Uber's bug bounty programme. By setting the payment method on a ride request to an invalid value, he could take rides that were never charged. The request was accepted and the car dispatched; the payment method was only exercised at the end of the trip, when it could no longer be charged. Uber fixed it after the report.

dispatch.js is a reconstruction: requestRide dispatches a car for any payment method id, and completeRide records the charge failure and completes the trip anyway.

Fix requestRide so an unchargeable payment method is refused before a car is dispatched.

Code map

var payments = require("./payments");

exports.requestRide = function (account, request, trips) {
  var trip = {
    id: "trip-" + (trips.length + 1),
    rider: account.id,
    paymentMethodId: request.paymentMethodId,
    fare: request.fare,
    status: "dispatched"
  };
  trips.push(trip);
  return { ok: true, trip: trip };
};

exports.completeRide = function (account, trip, ledger) {
  var method = account.paymentMethods[trip.paymentMethodId];
  try {
    payments.charge(method, trip.fare, ledger);
  } catch (e) {
    trip.chargeError = e.message;
  }
  trip.status = "completed";
  return trip;
};

Sign in to edit the file, run the tests and submit a fix

A free account — no card, no trial clock. You come straight back here.

The Payment Method Called Nothing — JavaScript Bug Hunt

Modelled on the Uber free-rides bug that security researcher Anand Prakash disclosed in 2017 after reporting it through Uber's bug bounty programme.

  • Language: JavaScript
  • Layer: Backend
  • Difficulty: Medium
  • Concepts: Payments, Validation
  • Modelled on: Uber · 2017
  • Visible tests: a ride on a verified card is dispatched and charged; an unsupported payment type is refused before dispatch
  • Reward: 50 XP for a complete fix

Incident

  • Severity: SEV-1 (priority: Critical (revenue))
  • Ticket: BUG-RIDE-FREE
  • Reported by: bug bounty
  • Time to fix: 20 minutes, the target for a medium incident

Failing checks on the shipped build

  • an unsupported payment type is refused before dispatch — expected {"ok":false,"error":"invalid_payment_method"} but got {"ok":true,"trip":{"id":"trip-1","rider":"rider-7","paymentMethodId":"pm_x","fare":1250,"status":"dispatched"}}

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Briefing

Modelled on the Uber free-rides bug that security researcher Anand Prakash disclosed in 2017 after reporting it through Uber's bug bounty programme. By setting the payment method on a ride request to an invalid value, he could take rides that were never charged. The request was accepted and the car dispatched; the payment method was only exercised at the end of the trip, when it could no longer be charged. Uber fixed it after the report.

dispatch.js is a reconstruction: requestRide dispatches a car for any payment method id, and completeRide records the charge failure and completes the trip anyway.

Fix requestRide so an unchargeable payment method is refused before a car is dispatched.

Bug report

BUG-RIDE-FREE · Priority: Critical (revenue) · Reported by: bug bounty

requestRide(account, request, trips):

  • look up account.paymentMethods[request.paymentMethodId]
  • if payments.isChargeable(method) is false (missing id, unknown id, unsupported type, unverified method), return { ok: false, error: "invalid_payment_method" } and push NO trip
  • otherwise push and return { ok: true, trip } with the trip as today (id "trip-<n>", status "dispatched")

completeRide charges the fare to the ledger exactly once for a valid trip.

Observed: a request with paymentMethodId pointing at type "xyz" is dispatched and completed; the ledger has no charge for it.

Logs

[dispatch] trip-8812 dispatched rider=rider-7 payment=pm_x
[billing] trip-8812 charge failed: payment method cannot be charged
[billing] trip-8812 completed fare=1250 collected=0

The code as shipped

src/rides/dispatch.js (editable)

var payments = require("./payments");

exports.requestRide = function (account, request, trips) {
  var trip = {
    id: "trip-" + (trips.length + 1),
    rider: account.id,
    paymentMethodId: request.paymentMethodId,
    fare: request.fare,
    status: "dispatched"
  };
  trips.push(trip);
  return { ok: true, trip: trip };
};

exports.completeRide = function (account, trip, ledger) {
  var method = account.paymentMethods[trip.paymentMethodId];
  try {
    payments.charge(method, trip.fare, ledger);
  } catch (e) {
    trip.chargeError = e.message;
  }
  trip.status = "completed";
  return trip;
};

Read-only context: src/rides/payments.js.

Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More JavaScript bug hunts.