The Preview That Minted Someone Else's Token — Bug Hunt
Modelled on Facebook's "View As" breach (disclosed September 2018): "View As" shows you your own profile as another person sees it.
- Language: JavaScript
- Layer: Backend
- Difficulty: Easy
- Concepts: Security, Auth
- Modelled on: Facebook · View As 2018
- Visible tests: your own page gets your own token; View As renders as the subject but mints for the viewer
- Reward: 50 XP for a complete fix
Incident
- Severity: SEV-1 (priority: Critical)
- Ticket: BUG-VIEWAS
- Reported by: security
- Time to fix: 10 minutes, the target for an easy incident
Failing checks on the shipped build
- View As renders as the subject but mints for the viewer — the token belongs to whoever is signed in: expected "tok-u_1001-1" but got "tok-u_2002-1"
How to work this incident
- Read the report: write down the expected behaviour and the actual one in a sentence each.
- Reproduce it: run the visible tests and find the failing check that matches the report.
- Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
- Follow the request through the handler, the validation and the service it calls; find the first step whose output disagrees with the report.
- Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.
Briefing
Modelled on Facebook's "View As" breach (disclosed September 2018): "View As" shows you your own profile as another person sees it. A combination of bugs meant that, in that mode, the video uploader generated an access token for the person being viewed as rather than for the viewer. Attackers chained this to collect tokens; Facebook first estimated almost 50 million affected accounts and later said about 29 million had tokens taken.
This project is a reconstruction. viewAs.js builds a render context in which user is the person the page is rendered as — and the composer mints its uploader token for ctx.user.
Fix the composer so a token is only ever minted for the authenticated viewer.
Bug report
BUG-VIEWAS · Priority: Critical · Reported by: security
renderPage(session, subjectId, tokens) returns { renderedAs, uploaderToken }:
- renderedAs is subjectId when it is given and differs from session.userId (View As mode), otherwise session.userId
- the uploader token is minted with tokens.mint(...) for session.userId — ALWAYS the authenticated viewer, never the subject — exactly once per render
buildContext(session, subjectId) returns { viewer, user, viewAs } in that key order.
Observed: in View As mode the page carries a working token for the person being previewed.
Logs
[viewas] viewer=u_1001 subject=u_2002 uploader token owner=u_2002The code as shipped
src/profile/viewAs.js (editable)
exports.buildContext = function (session, subjectId) {
var viewAs = !!subjectId && subjectId !== session.userId;
return {
viewer: session.userId,
user: viewAs ? subjectId : session.userId,
viewAs: viewAs
};
};
exports.renderComposer = function (ctx, tokens) {
var token = tokens.mint(ctx.user);
return { renderedAs: ctx.user, uploaderToken: token.token };
};
exports.renderPage = function (session, subjectId, tokens) {
return exports.renderComposer(exports.buildContext(session, subjectId), tokens);
};
Read-only context: src/profile/tokens.js.
Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More JavaScript bug hunts.