The Reducer That Bit the Hand

Medium

· Frontend

Incident

SEV-3

Time to fix: 20 min

Failing checks on the shipped build

  • adding returns a new state reference

    a new object must come back: expected a truthy value but got false

  • the previous state is untouched

    time-travel debugging depends on this: expected ["a"] but got ["a","b"]

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the value the screen shows back through the state and the pure helpers that compute it; the view is usually only the messenger.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Inspired by

Redux lore

Inspired by the debugging sessions behind every "my component won't re-render" question: the reducer mutates the existing state and returns the same object. Reference equality says nothing changed; memoised components agree; the UI freezes in time.

todosReducer.js must return new objects, never touch the old ones.

Code map

// Todos reducer.
exports.reduce = function (state, action) {
  if (action.type === "ADD_TODO") {
    state.items.push(action.text);
    return state;
  }
  return state;
};

Sign in to edit the file, run the tests and submit a fix

A free account — no card, no trial clock. You come straight back here.

The Reducer That Bit the Hand — JavaScript Bug Hunt

Inspired by the debugging sessions behind every "my component won't re-render" question: the reducer mutates the existing state and returns the same object.

  • Language: JavaScript
  • Layer: Frontend
  • Difficulty: Medium
  • Concepts: Immutability, State
  • Modelled on: Redux lore
  • Visible tests: adding returns a new state reference; the previous state is untouched
  • Reward: 50 XP for a complete fix

Incident

  • Severity: SEV-3
  • Time to fix: 20 minutes, the target for a medium incident

Failing checks on the shipped build

  • adding returns a new state reference — a new object must come back: expected a truthy value but got false
  • the previous state is untouched — time-travel debugging depends on this: expected ["a"] but got ["a","b"]

How to work this incident

  1. Read the report: write down the expected behaviour and the actual one in a sentence each.
  2. Reproduce it: run the visible tests and find the failing check that matches the report.
  3. Read the logs and the failing checks for the first value that is wrong — the earliest wrong value is nearer the cause than the loudest error.
  4. Follow the value the screen shows back through the state and the pure helpers that compute it; the view is usually only the messenger.
  5. Fix the cause rather than the symptom, run the visible tests again, and submit against the hidden ones — then write the root cause down.

Briefing

Inspired by the debugging sessions behind every "my component won't re-render" question: the reducer mutates the existing state and returns the same object. Reference equality says nothing changed; memoised components agree; the UI freezes in time.

todosReducer.js must return new objects, never touch the old ones.

Bug report

BUG-MUTATE · Reported by: web platform

reduce(state, action) for ADD_TODO:

  • returns a NEW state object with a NEW items array
  • the previous state object must remain EXACTLY as it was

Observed: state is mutated in place and returned as-is — memo checks see the same reference and skip the re-render.

Logs

[devtools] prevState === nextState -> render skipped (items differ!)

The code as shipped

src/store/todosReducer.js (editable)

// Todos reducer.
exports.reduce = function (state, action) {
  if (action.type === "ADD_TODO") {
    state.items.push(action.text);
    return state;
  }
  return state;
};

Open the hunt to start the incident clock, edit the files, run the visible tests and submit against the hidden ones, then write the root cause down. More JavaScript bug hunts.